Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lakectl upload using pre-signed use ContentMD5 header for ETag #6750

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix lakectl upload using pre-signed use ContentMD5 header for ETag #6750

merged 1 commit into from
Oct 11, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 10, 2023 •
edited
Loading

Close #6745

@nopcoder nopcoder added area/lakectl Issues related to lakeFS' command line interface (lakectl) include-changelog PR description should be included in next release changelog labels Oct 10, 2023
@nopcoder nopcoder self-assigned this Oct 10, 2023
@nopcoder nopcoder requested a review from guy-har October 10, 2023 21:58
@nopcoder nopcoder changed the title lakectl upload using pre-signed use ContentMD5 header for ETag Fix lakectl upload using pre-signed use ContentMD5 header for ETag Oct 10, 2023
@guy-har
Copy link
Contributor

guy-har commented Oct 11, 2023

@nopcoder looks like this solves the issue only for lakectl
What about the other clients (lakeFSFS, UI, and SDKs)? is it aligned with them? Also, what about GCP?

@nopcoder
Copy link
Contributor Author

nopcoder commented Oct 11, 2023 •
edited
Loading

@nopcoder looks like this solves the issue only for lakectl What about the other clients (lakeFSFS, UI, and SDKs)? is it aligned with them? Also, what about GCP?

#6751 solved the issue for lakeFSFS

Looking into the UI implementation now.
The client SDK itself is just API generated code which doesn't encapsulate how we extract ETag for uploaded content.

@nopcoder nopcoder force-pushed the fix/upload-presigned-checksum branch from a9f2bc7 to df351f2 Compare October 11, 2023 11:27
@nopcoder nopcoder merged commit aa099d0 into master Oct 11, 2023
@nopcoder nopcoder deleted the fix/upload-presigned-checksum branch October 11, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy-har guy-har guy-har approved these changes

Assignees

@nopcoder nopcoder

Labels
area/lakectl Issues related to lakeFS' command line interface (lakectl) include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align checksum in azure for upload response between pre-signed and not pre-signed
2 participants
@nopcoder @guy-har